Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Developer] Append better merge visibility to merge_arrow_pr.py #29301

Closed
asfimport opened this issue Aug 18, 2021 · 1 comment
Closed

[Developer] Append better merge visibility to merge_arrow_pr.py #29301

asfimport opened this issue Aug 18, 2021 · 1 comment

Comments

@asfimport
Copy link

asfimport commented Aug 18, 2021

dev/merge_arrow_pr.py is a nifty tool, but due to the way it avoids use of a GitHub-sanctioned merge it frequently confuses newcomers who see "closed" instead of "merged" PRs.

This could be ameliorated by automatically adding a comment to the PR directly after the "closed" event explaining that the PR is in fact merged and linking to an full breakdown of our alternative git flow.

Additionally for visibility in contexts where only the PR headline is visible it'd be useful to attach a "merged" label and/or place a [MERGED] tag in the title

Reporter: Ben Kietzman / @bkietz
Assignee: Kouhei Sutou / @kou

Related issues:

Note: This issue was originally created as ARROW-13664. Please see the migration documentation for further details.

@asfimport
Copy link
Author

David Li / @lidavidm:
This was fixed when we changed to using the GitHub API to merge pull requests.

 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants