Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Migrate ORCFileReader to Result<T> #29419

Closed
asfimport opened this issue Aug 30, 2021 · 3 comments
Closed

[C++] Migrate ORCFileReader to Result<T> #29419

asfimport opened this issue Aug 30, 2021 · 3 comments
Labels
Component: C++ Type: enhancement
Milestone
6.0.0

Comments

@asfimport
Copy link

ORCFileReader currently returns Status together with an out-pointer for most methods returning a useful value. New variants of these methods returning a Result<T> should be created, and the legacy variants be marked deprecated.

Reporter: Antoine Pitrou / @pitrou
Assignee: Junwang Zhao / @zhjwpku

PRs and other links:

Note: This issue was originally created as ARROW-13793. Please see the migration documentation for further details.
@asfimport
Copy link
Author

Junwang Zhao / @zhjwpku:
I will fire a PR on this issue if you don't mind, thanks :)

@asfimport
Copy link
Author

Junwang Zhao / @zhjwpku:
I am not sure I am using ARROW_DEPRECATED("Deprecated in 6.0.0.") the right way, comments pls.

@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 11065
#11065

@asfimport asfimport added this to the 6.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@asfimport