Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Uniform null handling in compute functions #29494

Closed
asfimport opened this issue Sep 3, 2021 · 1 comment
Closed

[C++] Uniform null handling in compute functions #29494

asfimport opened this issue Sep 3, 2021 · 1 comment
Assignees
Milestone

Comments

@asfimport
Copy link
Collaborator

The compute functions today have mixed support for null types.

Unary arithmetic functions (e.g. abs) don't support null arrays

Binary arithmetic functions (e.g. add) support one null array (e.g. int32 + null) but not both null arrays (i.e. null + null) but they do support both values being null (e.g. [null] + [null] = [null] if dtype=int32 but not supported if dtype=null)

sort_indices should support null arrays.

Some functions do forward null arrays:

  • unique

    Some functions output a non-null type given null inputs

  • is_null (=> boolean)

  • is_valid (=> boolean)

  • value_counts (=> struct)

  • dictionary_encode (=> dictionary)

  • count (=> int64)

    Some functions throw an error other than "not implemented"

  • list_parent_indices

Reporter: Weston Pace / @westonpace
Assignee: David Li / @lidavidm

PRs and other links:

Note: This issue was originally created as ARROW-13876. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 11255
#11255

@asfimport asfimport added this to the 6.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants