Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Consolidate utf8 benchmark #29846

Closed
asfimport opened this issue Oct 9, 2021 · 1 comment
Closed

[C++] Consolidate utf8 benchmark #29846

asfimport opened this issue Oct 9, 2021 · 1 comment

Comments

@asfimport
Copy link

I find some trivial (and obviously irrelevant) changes to UTF8 validation code may cause big variances to benchmark result.
UTF8 validation functions are inlined and called directly in benchmark. The compiler may try to optimize them together with the benchmark loop.
Un-inline the benchmark-ed functions makes the result predictable and explainable.

Reporter: Yibo Cai / @cyb70289
Assignee: Yibo Cai / @cyb70289

PRs and other links:

Note: This issue was originally created as ARROW-14269. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Yibo Cai / @cyb70289:
Issue resolved by pull request 11376
#11376

@asfimport asfimport added this to the 6.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants