Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] [CI] ensure that docker runs don't use host-built artifacts #30066

Closed
asfimport opened this issue Oct 28, 2021 · 8 comments
Closed

[R] [CI] ensure that docker runs don't use host-built artifacts #30066

asfimport opened this issue Oct 28, 2021 · 8 comments

Comments

@asfimport
Copy link

If someone already has some built files in arrow/r, the re-install sometimes does not pick this up and will lead to segfaults or other odities

Reporter: Jonathan Keane / @jonkeane
Assignee: Jonathan Keane / @jonkeane

PRs and other links:

Note: This issue was originally created as ARROW-14510. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Neal Richardson / @nealrichardson:
But it's expensive to always clean first. Why isn't "run make clean when building docs" an instruction for users for if/when they run into issues?

@asfimport
Copy link
Author

Jonathan Keane / @jonkeane:
We could add it to instructions, for the specifics of the docs build, that is quite a bit of waiting time since that build can take a while to complete or error out.

@asfimport
Copy link
Author

Jonathan Keane / @jonkeane:
Also, I can't think of an example where I would want built files from one docker image to be used by another (or from my local host used by docker). Is there a time where that's helpful?

@asfimport
Copy link
Author

Jonathan Keane / @jonkeane:
Totally agree that for R development locally it is helpful to not have to rebuild those files constantly

@asfimport
Copy link
Author

Jonathan Keane / @jonkeane:
Alternatively, we could do something in the docker builds that builds in a fresh(er) location that ignores the extras that are in the host system's arrow/R directory (R CMD BUILD . followed by R CMD INSTALL . might do that)

@asfimport
Copy link
Author

Jonathan Keane / @jonkeane:
Or by using R CMD INSTALL --preclean in arrow/ci/scripts/r_build.sh. And unless I'm mistaken, it looks like that shell script is only being used by the docs build?

@asfimport
Copy link
Author

Jonathan Keane / @jonkeane:
The sanitizer job also has this issue

@asfimport
Copy link
Author

Jonathan Keane / @jonkeane:
Issue resolved by pull request 11944
#11944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants