Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] arrowExports.cpp generation changed with glue package 1.5.1 #30566

Closed
asfimport opened this issue Dec 9, 2021 · 3 comments
Closed

[R] arrowExports.cpp generation changed with glue package 1.5.1 #30566

asfimport opened this issue Dec 9, 2021 · 3 comments

Comments

@asfimport
Copy link

When rendering arrowExports.cpp, if the latest glue release is installed (version 1.5.1), we get a huge diff. I imagine that we should update the generation script to render the previous version or somebody should commit the version with updated glue to avoid the file getting updated by too many PRs?

Reporter: Dewey Dunnington / @paleolimbot

PRs and other links:

Note: This issue was originally created as ARROW-15049. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Neal Richardson / @nealrichardson:
I don't see anything in glue's changelog that suggests that there was an intended change in behavior. Do you want to file an issue over there?

@asfimport
Copy link
Author

Dewey Dunnington / @paleolimbot:
Done! tidyverse/glue#247

(but also found an easy workaround in the process, hence the PR)

@asfimport
Copy link
Author

Jonathan Keane / @jonkeane:
Issue resolved by pull request 11936
#11936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant