Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Add OT spans for the scanner #30581

Closed
Tracked by #30574
asfimport opened this issue Dec 10, 2021 · 2 comments
Closed
Tracked by #30574

[C++] Add OT spans for the scanner #30581

asfimport opened this issue Dec 10, 2021 · 2 comments

Comments

@asfimport
Copy link

asfimport commented Dec 10, 2021

There should be one span for each "read batch" and one scan for each "read file". The batch spans should be children of the file span.

If possible it would be nice if the "read file" spans were children of the exec plan when the scanner is being used as a source node. I'm not sure if this is doable though since the scanner is often used outside the exec plan.

Reporter: Weston Pace / @westonpace
Assignee: Joost Hoozemans / @joosthooz

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-15067. Please see the migration documentation for further details.

@asfimport
Copy link
Author

David Li / @lidavidm:
Hmm, we could add a "parent span" or properly "parent span context" option to the scanner options. (That way you could link it up to a Flight span or something too.) You'd have to manually inject it to spans started in the scanner, though. (~2 lines of code or so for each span)

@asfimport
Copy link
Author

David Li / @lidavidm:
Issue resolved by pull request 12609
#12609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant