Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow R doesn't build correctly if Arrow C++ was configured with lowercase flags #30687

Closed
asfimport opened this issue Dec 22, 2021 · 1 comment
Assignees
Milestone

Comments

@asfimport
Copy link

I use to configure ARROW C++ using lowercase flag names "on" instead of {}"ON"{}, that works fine with the C++ library and Python library, but leads to build errors on R.

That's because the R build process looks for compile flags in ArrowOptions.cmake and those compile flags are compared with the uppercase ones.

So in my ArrowOptions.cmake I had

### Build the Parquet libraries
set(ARROW_PARQUET "on") 

while the R build script was looking for

grep 'set(ARROW_PARQUET "ON")' $ARROW_OPTS_CMAKE 

this can be addressed by making those greps case insensitive

Reporter: Alessandro Molina / @amol-
Assignee: Alessandro Molina / @amol-

PRs and other links:

Note: This issue was originally created as ARROW-15185. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Jonathan Keane / @jonkeane:
Issue resolved by pull request 12017
#12017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants