Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Create mapping from Substrait "standard functions" to Arrow equivalents #31009

Closed
asfimport opened this issue Feb 2, 2022 · 4 comments
Closed

Comments

@asfimport
Copy link
Collaborator

Substrait has a number of "stock" functions defined here: https://github.com/substrait-io/substrait/tree/main/extensions

This is basically a set of standard extensions.

We should map these functions to the equivalent Arrow functions.

Reporter: Weston Pace / @westonpace
Assignee: Tom Drabas / @drabastomek

PRs and other links:

Note: This issue was originally created as ARROW-15538. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Weston Pace / @westonpace:
Some of these mappings may get tricky because of differences in how Substrait & Arrow handle options. Note from @bkietz:

Options may only be enumerations. This will get strange with
functions like is_in, where we'll have to require that one argument is a literal
list or something.

@asfimport
Copy link
Collaborator Author

Nicola Crane / @thisisnic:
Wasn't sure if this ticket is likely to be divided into subtasks, but if it is, the items that would be highest priority right now for the folks working on the dplyr Substrait producer, (in terms of things that would enable us to run more of our tests) would be the comparison operators.  We'd also be happy to contribute/submit PRs for any of these if it's fairly simple to add more once one is already mapped.

@asfimport
Copy link
Collaborator Author

Apache Arrow JIRA Bot:
This issue was last updated over 90 days ago, which may be an indication it is no longer being actively worked. To better reflect the current state, the issue is being unassigned per project policy. Please feel free to re-take assignment of the issue if it is being actively worked, or if you plan to start that work soon.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 14434
#14434

@asfimport asfimport added this to the 11.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant