Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Allow user to supply col_names argument when reading in a CSV dataset #31253

Closed
Tracked by #33520
asfimport opened this issue Mar 1, 2022 · 3 comments
Closed
Tracked by #33520
Assignees
Milestone

Comments

@asfimport
Copy link

Allow the user to supply the col_names argument from readr when reading in a dataset.

This is already possible when reading in a single CSV file via arrow::read_csv_arrow() via the readr_to_csv_read_options function, and so once the C++ functionality to autogenerate column names for Datasets is implemented, we should hook up readr_to_csv_read_options in csv_file_format_read_opts just like we have with readr_to_csv_parse_options in csv_file_format_parse_options.

Reporter: Will Jones / @wjones127
Assignee: Will Jones / @wjones127

PRs and other links:

Note: This issue was originally created as ARROW-15812. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Nicola Crane / @thisisnic:
Is supporting logical values here actually going to be useful to users (in which case I need to open a C++ component ticket to enable autogeneration of column names for datasets), or would we be better enabling this argument, but testing the user-supplied value and if it's TRUE or FALSE, raise an error saying this isn't supported, but if it's a vector of column names just pass it through to the equivalent parameter (i.e. column_names)?

@asfimport
Copy link
Author

Will Jones / @wjones127:
Auto-generation of column names was added to Datasets in https://issues.apache.org/jira/browse/ARROW-16436

@asfimport
Copy link
Author

Nicola Crane / @thisisnic:
Issue resolved by pull request 14705
#14705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants