Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Python] Register Multiple Kernels for a UDF #31612

Open
Tracked by #31094
asfimport opened this issue Apr 18, 2022 · 7 comments
Open
Tracked by #31094

[C++][Python] Register Multiple Kernels for a UDF #31612

asfimport opened this issue Apr 18, 2022 · 7 comments

Comments

@asfimport
Copy link

The current UDF integration (https://issues.apache.org/jira/browse/ARROW-15639) doesn't support multiple kernel registration. It only supports registering a single kernel under a given function name. Enabling multiple kernels to be registered under the same function name is a must for usability and consistency with the existing functions in the function registry. 

Reporter: Vibhatha Lakmal Abeykoon / @vibhatha
Assignee: Vibhatha Lakmal Abeykoon / @vibhatha

PRs and other links:

Note: This issue was originally created as ARROW-16212. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Todd Farmer / @toddfarmer:
This issue was last updated over 90 days ago, which may be an indication it is no longer being actively worked. To better reflect the current state, the issue is being unassigned per project policy. Please feel free to re-take assignment of the issue if it is being actively worked, or if you plan to start that work soon.

@asfimport
Copy link
Author

Vibhatha Lakmal Abeykoon / @vibhatha:
Restarting the work on this ticket.

@asfimport
Copy link
Author

A. Coady / @coady:
Is any support for type aliases planned? It can be tedious to list every precision and resolution for a function that supports most types.

@asfimport
Copy link
Author

Vibhatha Lakmal Abeykoon / @vibhatha:
I see your point. This PR is still under review, once we move forward we will consider about such features.

cc @westonpace  

@asfimport
Copy link
Author

Vibhatha Lakmal Abeykoon / @vibhatha:
For some reason the Jira is not picking up the PR.

cc @westonpace  

@asfimport
Copy link
Author

Weston Pace / @westonpace:
Sorry for the delay in reviewing. I put in a review now. @coady, do you feel @vibhatha's change in the PR (being able to specify a list of supported types) would address your needs?

@asfimport
Copy link
Author

A. Coady / @coady:

@coady, do you feel @vibhatha's change in the PR (being able to specify a list of supported types) would address your needs?
Yeah, thanks, I think that's fine for the initial implementation.

Just something to keep in mind for future user-friendliness. It could be as simple as providing some pre-defined lists: all the int types, all the float types, etc.

@asfimport asfimport added this to the 11.0.0 milestone Jan 11, 2023
@raulcd raulcd removed this from the 11.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants