[C++] Update uri_path parsing in FromProto

[asfimport]

FromProto function in arrow/engine/substrait/relation_internal.cc parse uri_path with string_view utilities. However this should be done with Uri class from arrow/util/uri.h.

else if (util::string_view{path}.ends_with(".arrow")) {
  format = std::make_shared<dataset::IpcFileFormat>();
} else if (util::string_view{path}.ends_with(".feather")) {
  format = std::make_shared<dataset::IpcFileFormat>();

Reporter: Ariana Villegas / @ArianaVillegas
Assignee: Aldrin Montana / @drin

Related issues:

• [C++] Substrait consumer cannot handle file URIs that contain a Windows drive letter (is duplicated by)
• [Python] Sustrait-related test failure in wheel tests (causes)

PRs and other links:

• GitHub Pull Request #13390
• GitHub Pull Request #14071

_{Note: This issue was originally created as ARROW-16424. Please see the migration documentation for further details.}

[asfimport]

Weston Pace / @westonpace:
When writing the python Substrait consumer we disabled one of the tests on Windows due to this issue (it was described as ARROW-16392 which is a duplicate of this issue). When this is fixed we should make sure to re-enable the test.

[asfimport]

Aldrin Montana / @drin:
I wanted to note some of the unit tests that were disabled due to ARROW-16392, which can be re-enabled when this is addressed:

• DeserializeWithConsumerFactory

• DeserializeSinglePlanWithConsumerFactory

• DeserializeWithWriteOptionsFactory

• GetRecordBatchReader

  (as of commit ff3aa3b)

[asfimport]

Aldrin Montana / @drin:
I have assigned this issue to myself. I tried to extend PR#13390, but that became complicated after I rebased.

 

I have created PR#14071 for reference, but I will also try to coordinate with @vibhatha  for ARROW-16855.

[asfimport]

Antoine Pitrou / @pitrou:
Issue resolved by pull request 14071
#14071