You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the conversion between Acero and Substrait plans is done ad hoc using various overloads of the ToProto and FromProto functions. Code quality may benefit from refactoring this to a visitor pattern, to make it more easy to track state (ExtensionSet), store conversion options, maybe make multiple implementations in the future via inheritance, etc.
It's probably better to do this sooner rather than later (if we're going to do it).
Currently, the conversion between Acero and Substrait plans is done ad hoc using various overloads of the ToProto and FromProto functions. Code quality may benefit from refactoring this to a visitor pattern, to make it more easy to track state (ExtensionSet), store conversion options, maybe make multiple implementations in the future via inheritance, etc.
It's probably better to do this sooner rather than later (if we're going to do it).
Reporter: Jeroen van Straten / @jvanstraten
Note: This issue was originally created as ARROW-16987. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: