Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Refactor Substrait ToProto/FromProto to visitor pattern #32301

Open
asfimport opened this issue Jul 6, 2022 · 0 comments
Open

[C++] Refactor Substrait ToProto/FromProto to visitor pattern #32301

asfimport opened this issue Jul 6, 2022 · 0 comments

Comments

@asfimport
Copy link

Currently, the conversion between Acero and Substrait plans is done ad hoc using various overloads of the ToProto and FromProto functions. Code quality may benefit from refactoring this to a visitor pattern, to make it more easy to track state (ExtensionSet), store conversion options, maybe make multiple implementations in the future via inheritance, etc.

It's probably better to do this sooner rather than later (if we're going to do it).

Reporter: Jeroen van Straten / @jvanstraten

Note: This issue was originally created as ARROW-16987. Please see the migration documentation for further details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant