Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][FlightRPC] flight-core and flight-sql jars delivering same class names #32363

Closed
asfimport opened this issue Jul 12, 2022 · 2 comments
Closed

Comments

@asfimport
Copy link

Hello. I am trying to uptake arrow flight sql. We have a check in out build to make sure that there are no overlapping class files in our project. When adding the flight sql dependency to our project the warning throws that flight-sql and flight-core overlap and the jars deliver the same class files.

Sample Warning: WARNING: CLASSPATH OVERLAP: These jars deliver the same class files: [flight-sql-7.0.0.jar, flight-core-7.0.0.jar] files: [org/apache/arrow/flight/impl/Flight$FlightDescriptor$1.class, org/apache/arrow/flight/impl/Flight$ActionOrBuilder.class

 
It seems that the classes generated by Flight.proto gets generated in both flight-sql and flight-core jars. Since these classes get generated in flight-core, and flight-sql is dependent on flight-core, can the generation of Flight.java and FlightServiceGrpc.java be removed from flight-sql and instead rely on it to be pulled directly from flight-core?
 
thanks in advance!

Reporter: Kevin Bambrick / @KBambrick1
Assignee: Kevin Bambrick / @KBambrick1

PRs and other links:

Note: This issue was originally created as ARROW-17055. Please see the migration documentation for further details.

@asfimport
Copy link
Author

David Li / @lidavidm:
Yup, those classes shouldn't make it into both jars. (What do you use for this check? Ideally we'd set up a similar one.)

CC @davisusanibar  

@asfimport
Copy link
Author

David Li / @lidavidm:
Issue resolved by pull request 13596
#13596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant