Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Update remove old artifacts release script #32572

Open
asfimport opened this issue Aug 3, 2022 · 11 comments
Open

[Release] Update remove old artifacts release script #32572

asfimport opened this issue Aug 3, 2022 · 11 comments

Comments

@asfimport
Copy link

I just executed the remove old artifacts release script which also removed the previously created three patch releases for 6.0.2, 7.0.1, 8.0.1.

That's not desirable since those have just been released so I had to revert to an earlier revision.

cc @kou @assignUser @raulcd

Reporter: Krisztian Szucs / @kszucs
Assignee: Kouhei Sutou / @kou

Note: This issue was originally created as ARROW-17294. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Kouhei Sutou / @kou:
We need to discuss our maintenance policy. For example, we maintain the last 3 major releases (9.Y.Z, 8.Y.Z and 7.Y.Z).
If we have our maintenance policy, we can determine unmaintained versions automatically.

@asfimport
Copy link
Author

@asfimport asfimport added this to the 11.0.0 milestone Jan 11, 2023
@raulcd raulcd removed this from the 11.0.0 milestone Jan 11, 2023
@h-vetinari
Copy link
Contributor

h-vetinari commented Apr 15, 2023

So currently, there's only arrow 11 present under https://dist.apache.org/repos/dist/release/arrow anymore. Whatever the implicit/explicit support policy that's decided, I think it's a bad idea to remove the source release tarballs (we're supporting the last 4 versions in conda-forge -- 5 while we're transitioning to any new version --; we regularly need to rebuild those branches and were relying on those URLs, e.g. conda-forge/arrow-cpp-feedstock#1017 broke; I can switch to GH sources, but then what's the point of publishing tarballs at all?).

@kou
Copy link
Member

kou commented Apr 15, 2023

@h-vetinari
Copy link
Contributor

Sure. Didn't know that URL style, thanks.

@h-vetinari
Copy link
Contributor

I don't see how this could be introspected though (being dynamic AFAICT), and so I think I'll stay with the github tags.

@kou
Copy link
Member

kou commented Apr 16, 2023

Sorry. I'm not sure what "introspected" means. Could you explain more?

FYI: Other packaging systems such as Conan, Homebrew and MSYS2 also use the dyn/closer.lua style URL:

Conan:

Homebrew:

MSYS2:

@h-vetinari
Copy link
Contributor

Sorry. I'm not sure what "introspected" means. Could you explain more?

It cannot be taken apart and looked at. Or rather, when I do, I get to https://archive.apache.org/dist/arrow/arrow-10.0.0/, which actually looks way more useful that an url that's dynamically constructed (which is harder for the bots, harder for reproducibility -- even if you promise it --, etc.).

I don't speak for the other packaging systems, but I will always prefer source urls that are as simple possible (i.e. non-magical, not dynamically constructed...), and so I'd always take https://github.com/apache/arrow/archive/refs/tags/apache-arrow-{{ version }}.tar.gz or https://archive.apache.org/dist/arrow/arrow-{{ version }}/apache-arrow-{{ version }}.tar.gz over https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/arrow-11.0.0/apache-arrow-11.0.0.tar.gz

@kou
Copy link
Member

kou commented Apr 17, 2023

Hmm. conan-io/conan-center-index#14431 (comment) thread may help you.

@h-vetinari
Copy link
Contributor

Thanks. But it's not adding new information. Well, except that with the policy of only keeping the last 3 releases online, I've got one more argument for using the GitHub tags.

@kou
Copy link
Member

kou commented Apr 17, 2023

I can't stop you from using the GitHub tags but please keep in mind that they are NOT our "official" releases.
See also: https://www.apache.org/legal/release-policy.html
Especially: https://www.apache.org/legal/release-policy.html#publication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants