Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Remove as.factor to dictionary_encode mapping #32643

Closed
asfimport opened this issue Aug 10, 2022 · 1 comment
Closed

[R] Remove as.factor to dictionary_encode mapping #32643

asfimport opened this issue Aug 10, 2022 · 1 comment
Assignees
@thisisnic
Labels
Component: R Type: enhancement
Milestone
10.0.0

Comments

@asfimport
Copy link
Collaborator

There is an NSE func mapping between base::as.factor and Acero's dictionary_encode. However, it doesn't work at present - see ARROW-12632. Calling this function results in an error. We should remove this mapping so that an error is raised and we call as.factor in R not Acero.

Reporter: Nicola Crane / @thisisnic
Assignee: Nicola Crane / @thisisnic

PRs and other links:

Note: This issue was originally created as ARROW-17371. Please see the migration documentation for further details.
@asfimport
Copy link
Collaborator Author

Nicola Crane / @thisisnic:
Issue resolved by pull request 13836
#13836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisnic thisisnic

Labels
Component: R Type: enhancement
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
2 participants
@thisisnic @asfimport