Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow parquet go is missing Power (ppc64le) specific utils implementations #32644

Closed
asfimport opened this issue Aug 10, 2022 · 1 comment
Closed

Comments

@asfimport
Copy link

When trying to build the feast go lib on ppc64le it fails because parquet internal seems to miss even the basic (pure go implementations for ppc64le) files. Providing e.g. bit_packing_ppc64le.go & unpack_bool_ppc64le.go should solve this issue in the first place.

It can then be enhanced by implementing the correct vector & matrix intrinsics for the Power architecture (e.g. VSX or MMA) in a second step.

go build -mod=mod -buildmode=c-shared -tags cgo,ccalloc -o embedded_go.so .
cmd had error: exit status 2 output:
github.com/apache/arrow/go/v8/parquet/internal/utils
/root/go/pkg/mod/github.com/apache/arrow/go/v8@v8.0.0/parquet/internal/utils/bit_reader.go:230:18: undefined: unpack32
/root/go/pkg/mod/github.com/apache/arrow/go/v8@v8.0.0/parquet/internal/utils/bit_reader.go:274:3: undefined: BytesToBools
/root/go/pkg/mod/github.com/apache/arrow/go/v8@v8.0.0/parquet/internal/utils/bit_reader.go:318:18: undefined: unpack32 

I tested this already locally (with success) and create an according PR.

Environment: Linux (RHEL) ppc64le
Reporter: Marvin Giessing

PRs and other links:

Note: This issue was originally created as ARROW-17372. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Matthew Topol / @zeroshade:
Issue resolved by pull request 13840
#13840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant