Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Simplify async scheduler by removing the need to call End #32768

Closed
asfimport opened this issue Aug 24, 2022 · 1 comment
Closed

[C++] Simplify async scheduler by removing the need to call End #32768

asfimport opened this issue Aug 24, 2022 · 1 comment

Comments

@asfimport
Copy link

Right now the AsyncScheduler requires that we call End. This is to distinguish between a scheduler running out of tasks because it hit an idle period (in which case it shouldn't mark itself finished) and a scheduler running out of tasks because it is truly done (in which case it should mark itself finished).

It should be possible to require that scheduler tasks only be added by existing tasks. When creating a scheduler one would supply an "initial task" to bootstrap the first set of tasks. In this case we could get rid of the End method because the only time a scheduler will run out of tasks is when it is finished.

Reporter: Weston Pace / @westonpace
Assignee: Weston Pace / @westonpace

PRs and other links:

Note: This issue was originally created as ARROW-17509. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Weston Pace / @westonpace:
Issue resolved by pull request 14524
#14524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants