Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][CI] MinGW builds shouldn't compile grpcio #32803

Closed
asfimport opened this issue Aug 29, 2022 · 5 comments
Closed

[C++][CI] MinGW builds shouldn't compile grpcio #32803

asfimport opened this issue Aug 29, 2022 · 5 comments

Comments

@asfimport
Copy link
Collaborator

MinGW builds currently compile the GCS testbench and grpcio for MinGW.
When the compiled MinGW wheel is not in cache, compiling takes a very long time (\*). But Win32 and Win64 binary wheels are available on PyPI.

This is pointless: the GCS testbench could simply run with the system Python instead of the msys2 Python, and always use the binaries from PyPI.

(\*) see for example https://github.com/pitrou/arrow/runs/8071607360 where installing the GCS testbench took 18 minutes

Reporter: Antoine Pitrou / @pitrou
Assignee: Kouhei Sutou / @kou

PRs and other links:

Note: This issue was originally created as ARROW-17550. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
cc @kou

@asfimport
Copy link
Collaborator Author

Kouhei Sutou / @kou:
We couldn't choose the system Python approach when I implement this because there was cpp/src/arrow/python/.
But we can do it now because ARROW-16340 moved cpp/src/arrow/python/ to python/pyarrow/src/.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
@kou Would you like to prioritize this?

@asfimport
Copy link
Collaborator Author

Kouhei Sutou / @kou:
OK. I'll do it.

@asfimport
Copy link
Collaborator Author

Kouhei Sutou / @kou:
Issue resolved by pull request 14272
#14272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants