Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Refactor build_expr and eval_array_expression to remove special casing #32829

Open
asfimport opened this issue Aug 31, 2022 · 0 comments
Open

Comments

@asfimport
Copy link

As @paleolimbot observes here, we should avoid adding additional complexity or indirection in how expressions/bindings are defined--it's complex enough as is. We have helper functions build_expr (used with Acero, wrapper around Expression$create, returns Expression) and eval_array_expression (for eager computation on Arrays, wrapper around call_function) that wrap input arguments as Scalars or whatever, but they also do some special casing for functions that need custom handling.

However, since those functions were initially written, we've developed other ways to handle these special cases more explicitly, and not all operations pass through these helper functions. We should pull out the special cases and define those functions/bindings explicitly and only use these helpers in the simple case where no extra logic is required.

Reporter: Neal Richardson / @nealrichardson
Assignee: Neal Richardson / @nealrichardson

Note: This issue was originally created as ARROW-17581. Please see the migration documentation for further details.

@thisisnic thisisnic modified the milestones: 12.0.0, 13.0.0 Apr 11, 2023
@raulcd raulcd modified the milestones: 13.0.0, 14.0.0 Jul 7, 2023
@raulcd raulcd modified the milestones: 14.0.0, 15.0.0 Oct 10, 2023
@raulcd raulcd removed this from the 15.0.0 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants