Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Use [[nodiscard]] #33027

Closed
asfimport opened this issue Sep 21, 2022 · 1 comment
Closed

[C++] Use [[nodiscard]] #33027

asfimport opened this issue Sep 21, 2022 · 1 comment

Comments

@asfimport
Copy link
Collaborator

asfimport commented Sep 21, 2022

We currently have a ARROW_MUST_USE_TYPE macro that's only enabled on clang-based builds.
Instead we can use the [[nodiscard]] that's standard in C++17.

Reporter: Antoine Pitrou / @pitrou
Assignee: Antoine Pitrou / @pitrou

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-17803. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 14193
#14193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants