Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Remove make_unique reimplementation #33037

Closed
asfimport opened this issue Sep 22, 2022 · 3 comments
Closed

[C++] Remove make_unique reimplementation #33037

asfimport opened this issue Sep 22, 2022 · 3 comments
Labels
Component: C++ Type: task
Milestone
10.0.0

Comments

@asfimport
Copy link

asfimport commented Sep 22, 2022 •
edited

The make_unique reimplementation in arrow/util/make_unique.h can simply be replace with std::make_unique.

Reporter: Antoine Pitrou / @pitrou
Assignee: Gang Wu / @wgtmac

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-17814. Please see the migration documentation for further details.
@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
@wgtmac Do you want to submit a PR?

@asfimport
Copy link
Author

Gang Wu / @wgtmac:
@pitrou Sure, I will work on it.

@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 14204
#14204

@asfimport asfimport mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: C++ Type: task
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
1 participant
@asfimport