Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Accept bytes object in pyarrow.substrait.run_query #33152

Closed
asfimport opened this issue Oct 5, 2022 · 2 comments
Closed

[Python] Accept bytes object in pyarrow.substrait.run_query #33152

asfimport opened this issue Oct 5, 2022 · 2 comments

Comments

@asfimport
Copy link
Collaborator

pyarrow.substrait.run_query() only accepts a PyArrow buffer, and will segfault if something else is passed. People might try to pass a Python bytes object, which isn't unreasonable. For example, they might use the value returned by protobufs SerializeToString() function, which is Python bytes. At the very least, we should not segfault.

Reporter: Will Jones / @wjones127
Assignee: Miles Granger / @milesgranger

PRs and other links:

Note: This issue was originally created as ARROW-17944. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
cc @milesgranger

@asfimport
Copy link
Collaborator Author

Joris Van den Bossche / @jorisvandenbossche:
Issue resolved by pull request 14331
#14331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants