Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev][Archery][Crossbow] Comment report bot uses the wrong URL if task run has not started #33283

Open
asfimport opened this issue Oct 18, 2022 · 2 comments

Comments

@asfimport
Copy link

As discussed on this comment:

#14446 (comment)

Sometimes the task URL that we use on the report is not correct because the job run has not yet started on GitHub forcing us to wait and if not found using the branch URL. On those cases we should use the URL we used to use before ARROW-18028 was merged:

https://issues.apache.org/jira/browse/ARROW-18028

1e481b5

On the case of GitHub:

https://github.com/{repo}/actions?query=branch:{branch} 

Reporter: Raúl Cumplido / @raulcd

Original Issue Attachments:

Note: This issue was originally created as ARROW-18085. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Raúl Cumplido / @raulcd:
@kou what do you think about falling back to the previous URL if the task URL is not present because the run has not started? I am happy to work on it.

@asfimport
Copy link
Author

Kouhei Sutou / @kou:
How about increasing wait time to 3 minutes or something (or retry N times such as 1 minute wait + 3 retries)?

I'm OK with using the previous URL for GitHub Actions because we can go to the task URL with 1 click.
Example: https://github.com/ursacomputing/crossbow/actions?query=branch:lz4-bump-0-github-test-alpine-linux-cpp
Azure Pipelines is also OK: https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-79ea095ba1-azure-conda-win-vs2019-py310

But I don't want to use the previous URL for others (Travis CI for now because we use GitHub Actions, Azure Pipelines and Travis CI in dev/tasks/tasks.yml for now).
The previous URL for Travis CI is always https://app.travis-ci.com/github/ursacomputing/crossbow/branches . We can't find the task URL from the page...

BTW, I think that the current URL isn't so bad. We can go to the task URL with 2 clicks: ✓ -> Details
See also: task-url-link.png

@asfimport asfimport added this to the 11.0.0 milestone Jan 11, 2023
@raulcd raulcd removed this from the 11.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants