You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you used a different directory name for building Arrow C++ (by default it is named “build”), then you should also set the environment variable ARROW_BUILD_DIR='name_of_build_dir'. This way PyArrow can find the Arrow C++ built files.
I see in the setup.py code that we check for this env variable and pass it to CMake, but it's not actually used in any of the CMakeLists.txt files for pyarrow.
This might have been accidentally changed in one of the recent cmake refactors? (cc @kou@AlenkaF)
and most of it was included in the test section which is now removed. The rest of it was in the flight section which is now changed but I haven't been able to found a commit at this moment.
In any case, I think this variable is not needed anymore and can be removed. Great catch Joris!
Alenka Frim / @AlenkaF:
Ok, this is the commit that removed the code from the flight setup in PyArrow C++ CMake file 0eaf8e2 that used ARROW_BUILD_DIR.
It is completely safe and sensible to remove the env variable as it is not needed anymore - will make a PR.
When building pyarrow, I see the following warning:
While we have a note in our docs (https://arrow.apache.org/docs/dev/developers/python.html#build-and-test) that says:
I see in the setup.py code that we check for this env variable and pass it to CMake, but it's not actually used in any of the CMakeLists.txt files for pyarrow.
This might have been accidentally changed in one of the recent cmake refactors? (cc @kou @AlenkaF)
Reporter: Joris Van den Bossche / @jorisvandenbossche
Assignee: Alenka Frim / @AlenkaF
PRs and other links:
Note: This issue was originally created as ARROW-18126. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: