Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][FlightRPC] FlightSQL JDBC precludes other JDBC drivers on the same JVM #33472

Closed
asfimport opened this issue Nov 9, 2022 · 3 comments
Closed

Comments

@asfimport
Copy link

The contract of java.sql.Driver/connect says that the driver should return null if it realises it's the wrong kind of driver to handle the connection - unfortunately the override in ArrowFlightJdbcDriver throws an exception if the scheme isn't arrow-flight or arrow-flight-sql. So, if I'm trying to connect to (e.g.) postgres and the Arrow Flight driver happens to be first in the java.sql.DriverManager's list, I'll get a URL Scheme must be 'arrow-flight'. error.

We could consider a similar pattern to Avatica's UnregisteredDriver/connect, which checks acceptsURL first and returns null if appropriate?

(Separately, I suspect that error message should say arrow-flight-sql, given arrow-flight seems to be deprecated?)

Cheers,

James

Reporter: James Henderson / @jarohen
Assignee: David Li / @lidavidm

PRs and other links:

Note: This issue was originally created as ARROW-18296. Please see the migration documentation for further details.

@asfimport
Copy link
Author

David Li / @lidavidm:
D'oh, that's an obvious one. Thanks

@asfimport
Copy link
Author

James Henderson / @jarohen:
Heh :) Thanks for the prompt fix!

@asfimport
Copy link
Author

David Li / @lidavidm:
Issue resolved by pull request 14617
#14617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants