Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Failing test on test-r-rhub-ubuntu-gcc-release-latest #33564

Closed
asfimport opened this issue Nov 24, 2022 · 3 comments
Closed

[R] Failing test on test-r-rhub-ubuntu-gcc-release-latest #33564

asfimport opened this issue Nov 24, 2022 · 3 comments

Comments

@asfimport
Copy link

I think this is an R problem where there is a string that is not getting converted to a timestamp (given that the kernel that's mentioned that doesn't exist probably doesn't and shouldn't exist).

https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=40090&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=22256

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-dplyr-query.R:694'): Scalars in expressions match the type of the field, if possible ──
Error: NotImplemented: Function 'greater' has no kernel matching input types (timestamp[us, tz=UTC], string)
Backtrace:
     ▆
  1. ├─testthat::expect_output(...) at test-dplyr-query.R:694:2
  2. │ └─testthat:::quasi_capture(...)
  3. │   ├─testthat (local) .capture(...)
  4. │   │ └─testthat::capture_output_lines(code, print, width = width)
  5. │   │   └─testthat:::eval_with_output(code, print = print, width = width)
  6. │   │     ├─withr::with_output_sink(path, withVisible(code))
  7. │   │     │ └─base::force(code)
  8. │   │     └─base::withVisible(code)
  9. │   └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
 10. ├─tab %>% filter(times > "2018-10-07 19:04:05") %>% ...
 11. └─arrow::show_exec_plan(.)
 12.   ├─arrow::as_record_batch_reader(adq)
 13.   └─arrow:::as_record_batch_reader.arrow_dplyr_query(adq)
 14.     └─plan$Build(x)
 15.       └─node$Filter(.data$filtered_rows)
 16.         ├─self$preserve_extras(ExecNode_Filter(self, expr))
 17.         └─arrow:::ExecNode_Filter(self, expr)

Reporter: Dewey Dunnington / @paleolimbot
Assignee: Dewey Dunnington / @paleolimbot

PRs and other links:

Note: This issue was originally created as ARROW-18401. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Dewey Dunnington / @paleolimbot:
@nealrichardson I think this is something that went wrong with casting scalars to a common type. It's not clear to me that cast_scalars_to_common_type() is getting called from Expression$op() here but it's very odd that this is only happening on one platform.

@asfimport
Copy link
Author

Neal Richardson / @nealrichardson:
Right, it's failing to cast that string to timestamp so it's leaving it as string, and then there's no kernel available. The cast error is swallowed. cast_or_parse(Scalar$create("2018-10-07 19:04:05"), timestamp("us", "UTC")) would show the cast error.

@asfimport
Copy link
Author

Dewey Dunnington / @paleolimbot:
Issue resolved by pull request 14894
#14894

@asfimport asfimport added this to the 11.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants