Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [R] Fix repository URL configurations for pkgdown website #34276

Merged
merged 2 commits into from Feb 22, 2023

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Feb 21, 2023

Rationale for this change

When manually setting repository URLs for pkgdown, four different URLs could be set (home, source, issue, user).
https://pkgdown.r-lib.org/reference/build_site.html#source-repository

Because two of these (home, user) are not configured, the link to the repository home (the GitHub icon in the upper right corner of the menu bar) and the links to the users (the links from the account names on Changelog to the GitHub account) are currently not enabled on the arrow package website.

What changes are included in this PR?

Set up a link to the repository home and links to the users so that pkgdown's ability to link to the repository is fully functional.

Are these changes tested?

I built the website locally by using the pkgdown::build_site_github_pages() and verified that the link works.

Are there any user-facing changes?

No.

Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
@eitsupi
Copy link
Contributor Author

eitsupi commented Feb 21, 2023

@github-actions crossbow submit preview-docs

@github-actions
Copy link

Revision: c870097

Submitted crossbow builds: ursacomputing/crossbow @ actions-1300d85c32

Task Status
preview-docs Github Actions

@paleolimbot
Copy link
Member

I checked the GitHub link in the preview docs works...thank you!

@paleolimbot paleolimbot merged commit 0d9c0e7 into apache:main Feb 22, 2023
@eitsupi eitsupi deleted the r-pkgdown-user-link branch February 22, 2023 08:36
@ursabot
Copy link

ursabot commented Feb 22, 2023

Benchmark runs are scheduled for baseline = 5c61cbc and contender = 0d9c0e7. 0d9c0e7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.43% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.29% ⬆️0.06%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 0d9c0e7c ec2-t3-xlarge-us-east-2
[Finished] 0d9c0e7c test-mac-arm
[Finished] 0d9c0e7c ursa-i9-9960x
[Finished] 0d9c0e7c ursa-thinkcentre-m75q
[Finished] 5c61cbcf ec2-t3-xlarge-us-east-2
[Failed] 5c61cbcf test-mac-arm
[Finished] 5c61cbcf ursa-i9-9960x
[Finished] 5c61cbcf ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Feb 24, 2023
…che#34276)

### Rationale for this change

When manually setting repository URLs for pkgdown, four different URLs could be set (home, source, issue, user).
https://pkgdown.r-lib.org/reference/build_site.html#source-repository

Because two of these (home, user) are not configured, the link to the repository home (the GitHub icon in the upper right corner of the menu bar) and the links to the users (the links from the account names on Changelog to the GitHub account) are currently not enabled on the `arrow` package website.

### What changes are included in this PR?

Set up a link to the repository home and links to the users so that pkgdown's ability to link to the repository is fully functional.

### Are these changes tested?

I built the website locally by using the `pkgdown::build_site_github_pages()` and verified that the link works.

### Are there any user-facing changes?

No.

Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants