GH-35952: [R] Ensure that schema metadata can actually be set as a named character vector #35954
Conversation
|
|
github-actions
bot
added
Component: R
awaiting committer review
github-actions
bot
added
awaiting merge
…s a named character vector (apache#35954) This wasn't necessarily a regression (reprex fails in 12.0.0 as well), although the comments suggest that assigning a named character vector will work when assigning schema metadata and this feature appears to be used by at least one of our dependencies (sfarrow). Given that the sfarrow check passes on 12.0.0, there is possibly also a place in our code that returns a named character vector rather than a list. I've confirmed that this fix solves the reverse dependency failure building the sfarrow example vignette. ``` r library(arrow, warn.conflicts = FALSE) schema <- schema(x = int32()) schema$metadata <- c("name" = "value") schema$metadata #> $name #> [1] "value" ``` <sup>Created on 2023-06-06 with [reprex v2.0.2](https://reprex.tidyverse.org)</sup> * Closes: apache#35952 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
|
Benchmark runs are scheduled for baseline = e7a9b29 and contender = fe6c067. fe6c067 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
…s a named character vector (apache#35954) This wasn't necessarily a regression (reprex fails in 12.0.0 as well), although the comments suggest that assigning a named character vector will work when assigning schema metadata and this feature appears to be used by at least one of our dependencies (sfarrow). Given that the sfarrow check passes on 12.0.0, there is possibly also a place in our code that returns a named character vector rather than a list. I've confirmed that this fix solves the reverse dependency failure building the sfarrow example vignette. ``` r library(arrow, warn.conflicts = FALSE) schema <- schema(x = int32()) schema$metadata <- c("name" = "value") schema$metadata #> $name #> [1] "value" ``` <sup>Created on 2023-06-06 with [reprex v2.0.2](https://reprex.tidyverse.org)</sup> * Closes: apache#35952 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
This wasn't necessarily a regression (reprex fails in 12.0.0 as well), although the comments suggest that assigning a named character vector will work when assigning schema metadata and this feature appears to be used by at least one of our dependencies (sfarrow). Given that the sfarrow check passes on 12.0.0, there is possibly also a place in our code that returns a named character vector rather than a list. I've confirmed that this fix solves the reverse dependency failure building the sfarrow example vignette.
Created on 2023-06-06 with reprex v2.0.2