Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35949: [R] CSV File reader options class objects should print the selected values #35955

Merged
merged 4 commits into from
Jun 11, 2023

Conversation

thisisnic
Copy link
Member

@thisisnic thisisnic commented Jun 6, 2023

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jun 6, 2023
@thisisnic
Copy link
Member Author

I started on this as it'd be useful for some debugging I'm doing, though I wonder if there's a more efficient way of doing this than copying the code for each attribute. Perhaps not?

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me! This will almost certainly save you or somebody else some time in the future.

r/R/csv.R Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jun 6, 2023
@thisisnic thisisnic changed the title GH-35949: [R] File reader options class objects should print the selected values GH-35949: [R] CSV File reader options class objects should print the selected values Jun 6, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 6, 2023
@thisisnic thisisnic marked this pull request as ready for review June 6, 2023 18:31
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just one more test and it's good to go!

@@ -574,3 +574,11 @@ test_that("open_delim_dataset params passed through to open_dataset", {

expect_equal(ds$time, "16-01-2023")
})

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more test here for the data access part (as opposed to the printing part)? Like:

test_that("CSV options field access", {
  options <- CsvReadOptions$create(skip_rows = 102)
  expect_identical(options$skip_rows, 102)
  # ... for all the options we just added the ability to access
})

...for each option we added a

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jun 9, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 10, 2023
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jun 10, 2023
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I made a ticket for the CI failure, which seems to affect every debian/testing-based job: #36030

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Jun 11, 2023
@thisisnic thisisnic merged commit fe60932 into apache:main Jun 11, 2023
11 of 12 checks passed
@ursabot
Copy link

ursabot commented Jun 11, 2023

Benchmark runs are scheduled for baseline = 7887605 and contender = fe60932. fe60932 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0% ⚠️ Contender and baseline run contexts do not match] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.74% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.65% ⬆️0.0% ⚠️ Contender and baseline run contexts do not match] ursa-i9-9960x
[Finished ⬇️3.01% ⬆️0.3% ⚠️ Contender and baseline run contexts do not match] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] fe609322 ec2-t3-xlarge-us-east-2
[Finished] fe609322 test-mac-arm
[Finished] fe609322 ursa-i9-9960x
[Finished] fe609322 ursa-thinkcentre-m75q
[Finished] 78876057 ec2-t3-xlarge-us-east-2
[Finished] 78876057 test-mac-arm
[Finished] 78876057 ursa-i9-9960x
[Finished] 78876057 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R] CSV File reader options class objects should print the selected values
3 participants