GH-14969: [R][Docs] Enable pkgdown built-in search

[eitsupi]

Rationale for this change

Enable local search of pkgdown site.

What changes are included in this PR?

Remove some files that are not currently in use.

Are these changes tested?

There is no test, but the following functions can be run to verify that the site is working properly.

pkgdown::init_site("r")
pkgdown::build_search("r")
pkgdown::build_home("r")

Are there any user-facing changes?

No. Document changes only.

• Closes: [R] pkgdown built-in search doesn't work #14969

[github-actions]

⚠️ GitHub issue #14969 has been automatically assigned in GitHub to PR creator.

[eitsupi]

@github-actions crossbow submit preview-docs

[github-actions]

Revision: 553603d

Submitted crossbow builds: ursacomputing/crossbow @ actions-3581eef739

Task	Status
preview-docs

[eitsupi]

I am wondering if r/pkgdown/templates/navbar.html is also not currently in use and could be removed. (which seems to have nothing to do with fixing this issue)

[kou]

Preview: http://crossbow.voltrondata.com/pr_docs/36374/r/

It seems that search box works. Is this expected behavior?

[eitsupi]

It seems that search box works. Is this expected behavior?

Yes, I think it is working well.

[kou]

@thisisnic @paleolimbot Can we merge this?

[thisisnic]

Sorry for the delay on this, have been on holiday.

I am wondering if r/pkgdown/templates/navbar.html is also not currently in use and could be removed. (which seems to have nothing to do with fixing this issue)

Unsure without looking into this if it's a custom template or not, but open to removing it if it's not used - let's discuss in another issue.

Not a criticism but an FYI - I would have approved this sooner with a bit more information confirming that we no longer use the tabset functionality that is implemented in extra.js, but I had a scan through the code and it appears we no longer use this, so it looks good to remove it.

Thanks for investigating and fixing this @eitsupi, it'll be helpful to have the search functionality working now!

Before I merge this, would you mind removing the unused {.tabset} on line 90 in vignettes/developers/setup.Rmd? If you don't get to it before I get back, I'll push the change to the branch.

[eitsupi]

Thanks for review.

Not a criticism but an FYI - I would have approved this sooner with a bit more information confirming that we no longer use the tabset functionality that is implemented in extra.js, but I had a scan through the code and it appears we no longer use this, so it looks good to remove it.

Sorry, I didn't know extra.js had such a feature.

I believe pkgdown supports tabset by default.
https://pkgdown.r-lib.org/articles/test/rendering.html#tabsets

[eitsupi]

@github-actions crossbow submit preview-docs

[github-actions]

Revision: da3372c

Submitted crossbow builds: ursacomputing/crossbow @ actions-61b73bed14

Task	Status
preview-docs

[eitsupi]

Preview: http://crossbow.voltrondata.com/pr_docs/36374/r

Where can I look to find out this URL? (I recall it being listed in the GitHub Actions log, but I just looked and couldn't find it)

[kou]

See the summary view: https://github.com/ursacomputing/crossbow/actions/runs/5465384142#summary-14796723867

[eitsupi]

See the summary view: ursacomputing/crossbow/actions/runs/5465384142#summary-14796723867

Oh, I get it. Thanks.

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 05620b1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.