Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-36380: [R] Create convenience function arrow_array #36381

Merged
merged 3 commits into from Jun 29, 2023
Merged

GH-36380: [R] Create convenience function arrow_array #36381

merged 3 commits into from Jun 29, 2023

Conversation

thisisnic
Copy link
Member

@thisisnic thisisnic commented Jun 29, 2023 •
edited by github-actions bot

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jun 29, 2023
@thisisnic
Copy link
Member Author

@github-actions crossbow submit preview-docs

@github-actions
Copy link

Revision: 8f6febd

Submitted crossbow builds: ursacomputing/crossbow @ actions-efac4c7277

Task Status
preview-docs Github Actions

@thisisnic
Copy link
Member Author

Preview is here: http://crossbow.voltrondata.com/pr_docs/36381

@thisisnic thisisnic marked this pull request as ready for review June 29, 2023 16:15
paleolimbot
paleolimbot approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the parallel with arrow_table()! Thanks!

r/R/array.R Outdated

#' Create an Arrow Array
#'
#' @param x An R vector, list, or `data.frame`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "An R object representable as an Arrow array"? Or some combination of that and what's here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion, have incorporated, cheers!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 29, 2023
@github-actions github-actions bot added Component: R awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Jun 29, 2023
@thisisnic thisisnic merged commit 3fa7d60 into apache:main Jun 29, 2023
7 of 9 checks passed
@thisisnic thisisnic mentioned this pull request Jun 29, 2023
Closed
@kou kou mentioned this pull request Jun 30, 2023
Merged
@conbench-apache-arrow
Copy link

Conbench analyzed the 6 benchmark runs on commit 3fa7d603.

There were 5 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleolimbot paleolimbot paleolimbot approved these changes

Assignees
No one assigned
Labels
awaiting changes Awaiting changes Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[R] Create convenience function arrow_array
2 participants
@thisisnic @paleolimbot