Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MATLAB] arrow.array.Array subclasses should instantiate the Type property from a proxy ID #36555

Closed
sgilmore10 opened this issue Jul 7, 2023 · 2 comments
Closed

[MATLAB] arrow.array.Array subclasses should instantiate the Type property from a proxy ID #36555

sgilmore10 opened this issue Jul 7, 2023 · 2 comments
Assignees
@sgilmore10
Labels
Component: MATLAB Type: enhancement

Comments

@sgilmore10
Copy link
Member

Describe the enhancement requested

Now that DataType classes (e.g. arrow.type.Float64Type, arrow.type.TimestampType, etc) are implemented as proxy classes (#36419), we should construct the Type properties of the arrow.array.Array subclasses from the proxy IDs. This means the Type property on the MATLAB Array class and the type property within the underlying std::shared_ptr<arrow::Array> of the Array proxy class will refer to the same std::shared_ptr<arrow::DataType>.

Component(s)

MATLAB
@sgilmore10
Copy link
Member Author

take

@sgilmore10
Copy link
Member Author

I think I accidentally made two issues. This change was made by #36652.

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgilmore10 sgilmore10

Labels
Component: MATLAB Type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgilmore10