Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] the output is not passed to emitResult in scalarExecutor.executeSpans which may cause the function execute result is wrong #36592

Open
bigwhite opened this issue Jul 10, 2023 · 1 comment

Comments

@bigwhite
Copy link

Describe the bug, including details regarding any error messages, version, and platform.

When I read the code in executor.go, I found a maybe problem:

image

initially, output is a copy of prealloc. After some operation to output, the output may be different to prealloc, e.g. some slice header. (BufferSpan.Buf)

The code may pass the output to emitResult rather than the prealloc.

I'm not sure this is a real problem because I've no test case to produce the problem.

Component(s)

Go

@zeroshade
Copy link
Member

I think you might actually be correct here, it would be great if we could come up with a test case that exemplifies it first though before trying to put a fix in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants