Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36604: [Java][CI] Set up Arrow Java support for JDK8 and JDK11+ maven packaging #36605

Closed
wants to merge 3 commits into from

Conversation

davisusanibar
Copy link
Contributor

@davisusanibar davisusanibar commented Jul 11, 2023

Rationale for this change

To close #36604

What changes are included in this PR?

Set up Arrow Java support for JDK8 and JDK11+

Are these changes tested?

Yes, it is testing by github actions java jars

Are there any user-facing changes?

Yes

@github-actions
Copy link

⚠️ GitHub issue #36604 has been automatically assigned in GitHub to PR creator.

@davisusanibar davisusanibar changed the title GH-36604: [Java] Set up Arrow Java support for JDK8 and JDK11+ GH-36604: [Java][CI] Set up Arrow Java support for JDK8 and JDK11+ maven packaging Jul 11, 2023
@davisusanibar
Copy link
Contributor Author

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: 0542482

Submitted crossbow builds: ursacomputing/crossbow @ actions-20eaf46aae

Task Status
java-jars Github Actions

@davisusanibar
Copy link
Contributor Author

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: bc48907

Submitted crossbow builds: ursacomputing/crossbow @ actions-7e578d1b36

Task Status
java-jars Github Actions

@lidavidm
Copy link
Member

I thought the point is that we wouldn't support Java 8 after some date? Why are we building separate JARs for Java 8 when there's no point anyways? (We can't use any new language features, so we might as well stick with the current toolchain, if we are going to support Java 8.)

@davisusanibar
Copy link
Contributor Author

I thought the point is that we wouldn't support Java 8 after some date? Why are we building separate JARs for Java 8 when there's no point anyways? (We can't use any new language features, so we might as well stick with the current toolchain, if we are going to support Java 8.)

Hi @lidavidm, this draft PR shows how we can build Arrow Java using JDK8 & JDK11 and offer both versions independently. We will need to mark one version arrow in the future that will be the last to support JDK8, so we propose to tag them (ie: classifier jdk8).

Alternatively, we could defer this discussion until we have an agreement to deprecate JDK8 and only support JDK11.

Let me maintain this PR as a draft to I could continue when we have an agreement as a community to deprecate JDK8.

@lidavidm
Copy link
Member

lidavidm commented Aug 1, 2023

What is the point of building a separate JDK11 version from the same source code? We can't use Java 11 features anyways, so we may as well continue targeting Java 8.

@davisusanibar
Copy link
Contributor Author

What is the point of building a separate JDK11 version from the same source code? We can't use Java 11 features anyways, so we may as well continue targeting Java 8.

The significance of this only applies if we deprecate JDK8, in which case source/target should start with Java 11.

@lidavidm
Copy link
Member

lidavidm commented Aug 1, 2023

You can't target Java 8 when using Java 9+ features, so this is still pointless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java][CI] Set up Arrow Java support for JDK8 and JDK11+
2 participants