GH-37813: [R] add quoted_na argument to open_delim_dataset() #37828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: R
awaiting committer review
thisisnic
changed the title
paleolimbot
approved these changes
Sep 27, 2023
| @@ -253,7 +253,7 @@ test_that("readr parse options", { | |||
| tsv_dir, | |||
| partitioning = "part", | |||
| format = "text", | |||
| quo = "\"", | |||
| del = "," | |||
There was a problem hiding this comment.
Is this change intentional?
There was a problem hiding this comment.
Yep - because passing in a parameter as quo (not a valid parameter name) no longer constitutes a unique partial match to either the readr or arrow options, it is caught earlier on in input validation and so raises an "Unrecognized option" error instead of an "Ambiguous option" error. This input validation is something it would be nice to refactor in another PR, but I figured here we just want to replace quo with something else that takes us down the "Ambiguous option" path to stick with the spirit of the test.
r/tests/testthat/test-dataset-csv.R
Outdated
Comment on lines
567
to
568
| df <- data.frame(text = c("one", "two", "", "four"), num = 1:4) | ||
| write.csv(df, dst_file, row.names = FALSE, quote = FALSE) |
There was a problem hiding this comment.
Is this the same as write("one\ntwo\nthree\n\nfour") (It might be a tiny bit clearer what's actually getting tested to just write the contents of the file or put it in a comment...I forget what all the arguments of write.csv() actually do!)
github-actions
bot
added
awaiting merge
github-actions
bot
added
awaiting change review
github-actions
bot
added
awaiting change review
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 72c6497. There were 5 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…pache#37828) ### Rationale for this change The `open_delim_dataset()` family of functions were implemented to have the same arguments as the `read_delim_arrow()` functions where possible, but `quoted_na` was missed. ### What changes are included in this PR? Adding `quoted_na` to those functions. ### Are these changes tested? Yes ### Are there any user-facing changes? Yes **This PR includes breaking changes to public APIs.** Empty strings in input datasets now default to being read in by `open_delim_dataset()` and its derivates as NAs and not empty string * Closes: apache#37813 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…pache#37828) ### Rationale for this change The `open_delim_dataset()` family of functions were implemented to have the same arguments as the `read_delim_arrow()` functions where possible, but `quoted_na` was missed. ### What changes are included in this PR? Adding `quoted_na` to those functions. ### Are these changes tested? Yes ### Are there any user-facing changes? Yes **This PR includes breaking changes to public APIs.** Empty strings in input datasets now default to being read in by `open_delim_dataset()` and its derivates as NAs and not empty string * Closes: apache#37813 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…pache#37828) ### Rationale for this change The `open_delim_dataset()` family of functions were implemented to have the same arguments as the `read_delim_arrow()` functions where possible, but `quoted_na` was missed. ### What changes are included in this PR? Adding `quoted_na` to those functions. ### Are these changes tested? Yes ### Are there any user-facing changes? Yes **This PR includes breaking changes to public APIs.** Empty strings in input datasets now default to being read in by `open_delim_dataset()` and its derivates as NAs and not empty string * Closes: apache#37813 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#37828) ### Rationale for this change The `open_delim_dataset()` family of functions were implemented to have the same arguments as the `read_delim_arrow()` functions where possible, but `quoted_na` was missed. ### What changes are included in this PR? Adding `quoted_na` to those functions. ### Are these changes tested? Yes ### Are there any user-facing changes? Yes **This PR includes breaking changes to public APIs.** Empty strings in input datasets now default to being read in by `open_delim_dataset()` and its derivates as NAs and not empty string * Closes: apache#37813 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
open_delim_dataset()family of functions were implemented to have the same arguments as theread_delim_arrow()functions where possible, butquoted_nawas missed.What changes are included in this PR?
Adding
quoted_nato those functions.Are these changes tested?
Yes
Are there any user-facing changes?
Yes
This PR includes breaking changes to public APIs.
Empty strings in input datasets now default to being read in by
open_delim_dataset()and its derivates as NAs and not empty string