Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] pyarrow extension type is not converted to pandas properly in 13.0.0 #38014

Closed
paleolimbot opened this issue Oct 4, 2023 · 3 comments
Assignees
Labels
Milestone

Comments

@paleolimbot
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

Initially documented here: geoarrow/geoarrow-c#47

The implementation of the extension type is here:

https://github.com/geoarrow/geoarrow-python/blob/main/geoarrow-pyarrow/src/geoarrow/pyarrow/_type.py#L77-L78

I wonder if it has to do with the fact that there are subclasses of the extension type? (i.e., maybe I need to copy that pandas dtype method to all the subclasses?)

Component(s)

Python

@paleolimbot
Copy link
Member Author

Hmm...I tried adding the method to the subclasses but that didn't seem to do it. The PR where I'm trying to unpin the pyarrow dependency is here: geoarrow/geoarrow-python#25

@jorisvandenbossche jorisvandenbossche changed the title pyarrow extension type is not converted to pandas properly in 13.0.0 [Python] pyarrow extension type is not converted to pandas properly in 13.0.0 Oct 4, 2023
@jorisvandenbossche jorisvandenbossche added the Priority: Blocker Marks a blocker for the release label Oct 4, 2023
@jorisvandenbossche jorisvandenbossche added this to the 14.0.0 milestone Oct 4, 2023
@jorisvandenbossche jorisvandenbossche self-assigned this Oct 4, 2023
@jorisvandenbossche
Copy link
Member

Thanks for the context, will take a look!

@paleolimbot
Copy link
Member Author

Sorry for the noise...I'd defined another @property id. Until recently, that value hadn't been inspected to check if something was an extension type!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants