Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Parquet]: Add support for list view and large list view #38849

Open
mapleFU opened this issue Nov 22, 2023 · 2 comments · May be fixed by #38850
Open

[C++][Parquet]: Add support for list view and large list view #38849

mapleFU opened this issue Nov 22, 2023 · 2 comments · May be fixed by #38850

Comments

@mapleFU
Copy link
Member

mapleFU commented Nov 22, 2023

Describe the enhancement requested

Parquet itself doesn't has a LIST_VIEW type, however, we can read/write a LIST_VIEW inside parquet.

Some notes:

  1. During loading, I think making a arrow::list is ok, and converting a List to ListView is so convenient. So maybe we can first support write
  2. For parquet::arrow::SchemaManifest, maybe it's ok to just store a list as metadata?

TODO:

  1. For writer, we need support PathInfo. The logic is so similiar to origin list node, however, we need support a new kind of RangeSelector. We don't need to support a new list because the writer here doesn't make full use of the contigous array
  2. For schema, we need to handle the parquet/arrow/schema.h well.

Component(s)

C++, Parquet

@mapleFU
Copy link
Member Author

mapleFU commented Nov 22, 2023

@felipecrv @pitrou @wgtmac I'd like to support the write first, becausing reading List and casting to ListView is easy, but casting ListView to List during write is hard. What do you think?

@wgtmac
Copy link
Member

wgtmac commented Nov 23, 2023

You've just reminded me that the parity should be added to the ORC adapter as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants