Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Build Arrow as JPMS modules #38915

Open
jduo opened this issue Nov 28, 2023 · 5 comments
Open

[Java] Build Arrow as JPMS modules #38915

jduo opened this issue Nov 28, 2023 · 5 comments

Comments

@jduo
Copy link
Member

jduo commented Nov 28, 2023

Describe the enhancement requested

Allow Arrow to be referenced as JPMS modules when run in Java 9 and higher

This issue is broken down into the following sub-issues:

The memory module related issues affect the user's command-line and may be too much of a breaking change for users.

Component(s)

Java

@FiV0
Copy link
Contributor

FiV0 commented Apr 5, 2024

@jduo Could you maybe explain how this new plugin of #39134 is supposed to be used. Since a couple of these changes have gone in, I am unable to test in Intellij. I normally went through the process described at https://arrow.apache.org/docs/developers/java/building.html#intellij, but that doesn't work anymore.

I am currently getting:

java: modules are not supported in -source 8
  (use -source 9 or higher to enable modules)

@jduo
Copy link
Member Author

jduo commented Apr 5, 2024

@jduo Could you maybe explain how this new plugin of #39134 is supposed to be used. Since a couple of these changes have gone in, I am unable to test in Intellij. I normally went through the process described at https://arrow.apache.org/docs/developers/java/building.html#intellij, but that doesn't work anymore.

I am currently getting:

java: modules are not supported in -source 8
  (use -source 9 or higher to enable modules)

Hi @FiV0 . I've been able to get IntelliJ working by setting it to use maven for build and test rather than using it's built-in build system.

@FiV0
Copy link
Contributor

FiV0 commented Apr 5, 2024

Thanks for the quick turnaround @jduo . That seems then to create a rather long feedback cycle (as it tests all of java/vector for example). Do you then create specific tests goals for every test you want to run alone or do you have some other setup which doesn't need a setup for every test?

@vibhatha
Copy link
Collaborator

vibhatha commented Apr 5, 2024

@FiV0 what @jduo mentioned is the most convenient option. There is an alternative I use but when we use that we cannot compile the code using the IDE. By enabling Do not build before run and Do not use --module-path option in Modify Options under Run configs could also allow running test cases.

@jduo
Copy link
Member Author

jduo commented Apr 5, 2024

If I remember correctly, after you run the tests once in the IDE they'll appear in a list with results and you can run specific ones repeatedly afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants