Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Docs] Add an empty line to make .. code-block:: work correctly #39388

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

Thespica
Copy link
Contributor

Rationale for this change

Code block here didn't work correctly. Added a empty line to make it work well.

What changes are included in this PR?

Added a empty line to make it work correctly.

Are these changes tested?

No.

Are there any user-facing changes?

No.

@Thespica
Copy link
Contributor Author

Hi, @AlenkaF , could you please help review this PR?

This PR aims to fix the redundant .. code-block::. I guess it is because there isn't a shift so rst treats it as one sentence.

image

@Thespica Thespica changed the title MINOR: [Docs] Add a empty line to make .. code-block:: work correctly MINOR: [Docs] Add an empty line to make .. code-block:: work correctly Dec 31, 2023
@AlenkaF
Copy link
Member

AlenkaF commented Jan 3, 2024

Yes, this change should be correct.
Thank you for the PR!

@AlenkaF AlenkaF merged commit d75269f into apache:main Jan 3, 2024
8 checks passed
@AlenkaF AlenkaF removed the awaiting review Awaiting review label Jan 3, 2024
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jan 3, 2024
@Thespica Thespica deleted the patch-2 branch January 3, 2024 12:38
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d75269f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
…tly (apache#39388)

### Rationale for this change

Code block [here](https://arrow.apache.org/docs/developers/java/development.html#unit-testing) didn't work correctly. Added a empty line to make it work well.

### What changes are included in this PR?

Added a empty line to make it work correctly.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.

Authored-by: John <thespica@qq.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…tly (apache#39388)

### Rationale for this change

Code block [here](https://arrow.apache.org/docs/developers/java/development.html#unit-testing) didn't work correctly. Added a empty line to make it work well.

### What changes are included in this PR?

Added a empty line to make it work correctly.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.

Authored-by: John <thespica@qq.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
…tly (apache#39388)

### Rationale for this change

Code block [here](https://arrow.apache.org/docs/developers/java/development.html#unit-testing) didn't work correctly. Added a empty line to make it work well.

### What changes are included in this PR?

Added a empty line to make it work correctly.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.

Authored-by: John <thespica@qq.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants