Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Remove implicit workflow transitions #40296

Open
pitrou opened this issue Feb 29, 2024 · 5 comments
Open

[Dev] Remove implicit workflow transitions #40296

pitrou opened this issue Feb 29, 2024 · 5 comments

Comments

@pitrou
Copy link
Member

pitrou commented Feb 29, 2024

Describe the enhancement requested

Currently, some workflow transitions (using labels such as "awaiting review") are implicitly triggered on various events, such as posting a comment on a PR. This is both useless and confusing, because it does not mirror the actual state of a PR (you can post a comment without it being a review, for example).

We should disable those implicit transitions. Later we can implement explicit transitions, using dedicated user actions.

Component(s)

Developer Tools

@pitrou
Copy link
Member Author

pitrou commented Feb 29, 2024

Thoughts @jorisvandenbossche @felipecrv @kou @js8544 ?

@js8544
Copy link
Collaborator

js8544 commented Feb 29, 2024

PR labels are indeed very confusing sometimes. But I'm not sure what would explicit transitions look like? Could you give an example?

@pitrou
Copy link
Member Author

pitrou commented Feb 29, 2024

It looks like this, though it seems this bot is actually slightly broken:
python/cpython#115989 (comment)

@kou
Copy link
Member

kou commented Mar 1, 2024

I'm not using these labels. (I just ignore these labels.) So I don't have a strong opinion for this.
I'm using "new comment" email notifications as review/answer triggers.

@felipecrv
Copy link
Contributor

I never look at and never use the labels. My workflow is opening the "Participating" and "Mentioned" filters, and scanning from top to bottom for items with recent updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants