Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40573: [GLib][Ruby][CSV] Add support for customizing timestamp parsers #40590

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

kou
Copy link
Member

@kou kou commented Mar 16, 2024

Rationale for this change

ISO8601 timestamp values in CSV can be parsed by default but non-ISO8601 timestamp values can't.

What changes are included in this PR?

  • Add garrow_csv_read_options_set_timestamp_parsers()
  • Add garrow_csv_read_options_get_timestamp_parsers()
  • Add garrow_csv_read_options_add_timestamp_parser()
  • Add Arrow::TimestampParser.try_convert for implicit cast

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

Copy link

⚠️ GitHub issue #40573 has been automatically assigned in GitHub to PR creator.

@kou kou force-pushed the glib-csv-read-options-timestamp-parsers branch from d12c624 to 01d95fd Compare March 18, 2024 01:31
@kou
Copy link
Member Author

kou commented Mar 18, 2024

+1

@kou kou merged commit 7d3f7b3 into apache:main Mar 18, 2024
8 checks passed
@kou kou deleted the glib-csv-read-options-timestamp-parsers branch March 18, 2024 06:22
@kou kou removed the awaiting committer review Awaiting committer review label Mar 18, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 7d3f7b3.

There was 1 benchmark result with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant