Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOChannelUtils.getFactory should throw an unchecked exception rather than IOException #17875

Closed
damccorm opened this issue Jun 3, 2022 · 0 comments

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 3, 2022

In this PR, we've add a new method, IOChannelUtils.hasFactory, which provides a convenient way to verify that a factory exists before calling getFactory. As such, the IOException thrown by getFactory is extra cruft for consumers using the new pattern.

We should update additional consumers to check hasFactory first, and then migrate getFactory to throw a RuntimeException

Imported from Jira BEAM-281. Original Jira may contain additional context.
Reported by: swegner.

@damccorm damccorm closed this as completed Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant