Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remaining data types in python RowCoder #19815

Open
damccorm opened this issue Jun 4, 2022 · 0 comments
Open

Add support for remaining data types in python RowCoder #19815

damccorm opened this issue Jun 4, 2022 · 0 comments

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 4, 2022

In the initial python RowCoder implementation we only added support for the data types that already had coders in the Python SDK. We should add support for the remaining data types that are not currently supported:

  • INT8 (ByteCoder in Java)
  • INT16 (BigEndianShortCoder in Java)
  • FLOAT (FloatCoder in Java) (Note: doubles are supported, this is specifically for single-precision)
  • BOOLEAN (standard beam:coder:bool:v1, BooleanCoder in Java)
  • BYTES (standard beam:coder:bytes:v1, ByteArrayCoder in Java)
  • Map (MapCoder in Java)

We might consider making those coders standard so they can be tested independently from RowCoder in standard_coders.yaml. Or, if we don't do that we should probably add a more robust testing framework for RowCoder itself, because it will be challenging to test all of these types as part of the RowCoder tests in standard_coders.yaml.

Imported from Jira BEAM-7996. Original Jira may contain additional context.
Reported by: bhulette.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant