Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go SDK] starcgen improvements #20271

Open
damccorm opened this issue Jun 4, 2022 · 0 comments
Open

[Go SDK] starcgen improvements #20271

damccorm opened this issue Jun 4, 2022 · 0 comments

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 4, 2022

The starcgen code generator works OK, but could do with some improvements.

  • Uniquifying imports (handling multiple imports with same short suffix)
  • Generating multiple iterNatives (eg when the normal symbol is already taken).
  • Keying off of beam.Register* calls rather than command line.
    **  Avoids duplicating lists of identifiers, and improves default behavior.
    ** Possibly have a new beam.RegisterDoFn which can take a list of DoFn and struct types a function or a struct, and key off those, reducing boiler plate somewhat.
  • Perhaps having a specific single import alias package for components required for import, rather than the current 3-4.
  • Generate efficient Beam Schema coders for registered types?
  • Handle SplittableDoFns properly.

Imported from Jira BEAM-9616. Original Jira may contain additional context.
Reported by: lostluck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant