Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Move LogElements transform to Beam Transforms #23016

Closed
tvalentyn opened this issue Sep 2, 2022 · 2 comments · Fixed by #23879
Closed

[Feature Request]: Move LogElements transform to Beam Transforms #23016

tvalentyn opened this issue Sep 2, 2022 · 2 comments · Fixed by #23879
Labels
core done & done Issue has been reviewed after it was closed for verification, followups, etc. good first issue new feature P2 python

Comments

@tvalentyn
Copy link
Contributor

What would you like to happen?

People are re-implementing LogElements and asking about similar things on stackoverflow.

https://github.com/apache/beam/blob/master/learning/katas/python/log_elements.py

The LogElements is currently used in the educational tools (Katas, Playground) and not part of the official Beam API.

apache_beam/transforms or apache_beam/transforms/util.py may be a better home for it.

Issue Priority

Priority: 2

Issue Component

Component: sdk-py-core

@sreenath-tm
Copy link

I'm interested in contributing to this issue, so before I start working it, would you mind sparing your time explaining what the fix will be like and pointing me to some resources to get started.

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Sep 7, 2022

Hi @sreenath-tm . Thanks for considering contributing to Beam! You can take a look at https://beam.apache.org/contribute/get-started-contributing/ and s.apache.org/beam-python-dev-wiki to get started.

The fix looks like this: the transform code in https://github.com/apache/beam/blob/master/learning/katas/python/log_elements.py ,
is moved into https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/util.py any references to this code are updated.

Bonus: add a unit test that exercises the transform.

@github-actions github-actions bot added this to the 2.44.0 Release milestone Nov 1, 2022
@tvalentyn tvalentyn added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core done & done Issue has been reviewed after it was closed for verification, followups, etc. good first issue new feature P2 python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants