Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: multi_process_shared.py should not provide a default tag value #26168

Closed
1 of 15 tasks
damccorm opened this issue Apr 7, 2023 · 0 comments
Closed
1 of 15 tasks
Assignees
Labels
bug done & done Issue has been reviewed after it was closed for verification, followups, etc. P2 python

Comments

@damccorm
Copy link
Contributor

damccorm commented Apr 7, 2023

What happened?

Right now, MultiProcessShared accepts a tag input -

- that is set to None by default.

When the tag is set to None, it is set to a random value -

self._tag = tag or uuid.uuid4().hex
- since each process picks a different value, the object is not actually shared across processes (a shared instance of the object is instead created for each individual process).

Tag should not be None by default and probably should not even be optional since this is a misleading behavior. Note that this will be a breaking change for some users (if there are any), but those users are probably relying on buggy behavior anyways.

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@damccorm damccorm self-assigned this Apr 7, 2023
@damccorm damccorm added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Jun 21, 2023
@github-actions github-actions bot added this to the 2.49.0 Release milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug done & done Issue has been reviewed after it was closed for verification, followups, etc. P2 python
Projects
None yet
Development

No branches or pull requests

1 participant