Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task][Go SDK]: Remove reflect.Type parameter in parquetio.Write #28490

Closed
1 of 15 tasks
johannaojeling opened this issue Sep 16, 2023 · 1 comment · Fixed by #28491
Closed
1 of 15 tasks

[Task][Go SDK]: Remove reflect.Type parameter in parquetio.Write #28490

johannaojeling opened this issue Sep 16, 2023 · 1 comment · Fixed by #28491
Assignees

Comments

@johannaojeling
Copy link
Contributor

What needs to happen?

The parquetio.Write transform takes a t reflect.Type parameter, which is redundant since the type can be derived from the incoming PCollection.

It will be a backward incompatible change, however will be more consistent with the other IOs (bigqueryio, bigtableio and so on) and will remove the need for developers to write wrapper functions such as:

func WriteParquet(s beam.Scope, filename string, col beam.PCollection) {
    t := col.Type().Type()
    parquetio.Write(s, filename, t, col)
}

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@johannaojeling
Copy link
Contributor Author

.take-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant