Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Java expansion service does not respect the namespace for all environments. #30876

Open
1 of 16 tasks
robertwb opened this issue Apr 5, 2024 · 1 comment
Open
1 of 16 tasks

Comments

@robertwb
Copy link
Contributor

robertwb commented Apr 5, 2024

What happened?

This seems to primarily be leaking a unnamespaced "default" environment for the globally windowing strategy, which slides under the radar as the environment is not always inspected in this case, but it would be good to clean this up and add a check.

Issue Priority

Priority: 3 (minor)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@robertwb
Copy link
Contributor Author

robertwb commented Apr 5, 2024

This was uncovered by #30864

It can be reproduced with

import apache_beam as beam
from apache_beam.transforms import external
import logging

from apache_beam.utils import subprocess_server

logging.getLogger().setLevel(logging.INFO)

with beam.Pipeline('DirectRunner') as p:
  i1 = p | "i1" >> beam.Create([beam.Row(name='john', id=1)])
  i2 = p | "i2" >> beam.Create([beam.Row(name='jane', id=1)])
  result = {'i1': i1, 'i2': i2} | 'Sql1' >> external.ExternalTransform(
        'beam:external:java:sql:v1',
        external.ImplicitSchemaPayloadBuilder(
          {'query': 'SELECT * FROM i1 INNER JOIN i2 ON i1.id = i2.id'}
        ).payload(),
    external.JavaJarExpansionService(
      subprocess_server.JavaJarServer.path_to_beam_jar(
        gradle_target='sdks:java:extensions:sql:expansion-service:shadowJar',
        artifact_id=None
      )
    )) | 'LogForTesting' >> external.SchemaAwareExternalTransform(
        'beam:schematransform:org.apache.beam:yaml:log_for_testing:v1',
    external.JavaJarExpansionService(
      subprocess_server.JavaJarServer.path_to_beam_jar(
        gradle_target='sdks:java:extensions:sql:expansion-service:shadowJar',
        artifact_id=None
      )
    ), rearrange_based_on_discovery=True)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant