Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bookies hosts by metrics grow exponentially. #2736

Closed
thinker0 opened this issue Jun 10, 2021 · 10 comments
Closed

bookies hosts by metrics grow exponentially. #2736

thinker0 opened this issue Jun 10, 2021 · 10 comments
Labels

Comments

@thinker0
Copy link
Member

BUG REPORT
There are many, many, many Prometheus Metrics names.

Describe the bug

^(bookkeeper_client_per_channel_bookie_client|bookkeeper_server_BookieHighPriorityThread|replication_bookkeeper_client_per_channel_bookie_client)_hostnames_port_.*

bookies hosts by metrics grow exponentially.

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
Prometheus OOM (200Gbyte)

Screenshots
image
image

Additional context

Add any other context about the problem here.

@eolivelli
Copy link
Contributor

which version of BK are you using ?
how many bookies ?
do bookies have a dynamic address ?

@thinker0
Copy link
Member Author

thinker0 commented Jun 10, 2021

  • pulsar-2.7.2
  • 120ea bookies
  • yes (apache mesos/aurora)
    image

Change the metrics as shown below.

bookkeeper_client_per_channel_bookie_client...{instance="hostname:port"}

@thinker0
Copy link
Member Author

thinker0 commented Jun 10, 2021

Like this ? apache/incubator-heron#3493

@sursingh
Copy link
Contributor

I think this has already been addressed: https://github.com/apache/bookkeeper/blame/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java#L407

4.14.1 release should have this change

@thinker0
Copy link
Member Author

@sursingh Is it compatible with Pulsar 2.7.2 version?

@sursingh
Copy link
Contributor

2.7.2 is using bookkeeper 4.12.x so doesn't have this change. You may need to backport this to 4.12.x bookkeeper.

@thinker0
Copy link
Member Author

@sursingh
Copy link
Contributor

Binary jars can be downloaded from maven. https://mvnrepository.com/artifact/org.apache.bookkeeper/bookkeeper-server

@sijie
Copy link
Member

sijie commented Jun 11, 2021

@thinker0 Can you create an issue in Pulsar? We can upgrade the bookkeeper version for Pulsar 2.7.3 release.

@shoothzj
Copy link
Member

has been solved in 4.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants